Skip to content

Move release and tag version into env vars to prevent template injection #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 3 commits into from
Mar 17, 2026
Merged

Move release and tag version into env vars to prevent template injection #2909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9cf443
Move release and tag version into env vars to prevent template injection
adamtheturtle Mar 17, 2026
01e584b
Enable template-injection rule in zizmor config
adamtheturtle Mar 17, 2026
fa2cb9a
Fix template-injection in Check steps
adamtheturtle Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ jobs:

- name: Get the changelog underline
id: changelog_underline
env:
RELEASE: ${{ steps.calver.outputs.release }}
run: |
underline="$(echo "${{ steps.calver.outputs.release }}" | tr -c '\n' '-')"
underline="$(echo "$RELEASE" | tr -c '\n' '-')"
echo "underline=${underline}" >> "$GITHUB_OUTPUT"

- name: Update changelog
Expand All @@ -64,8 +66,10 @@ jobs:
regex: false

- name: Check Update changelog was modified
env:
MODIFIED_FILES: ${{ steps.update_changelog.outputs.modifiedFiles }}
run: |
if [ "${{ steps.update_changelog.outputs.modifiedFiles }}" = "0" ]; then
if [ "$MODIFIED_FILES" = "0" ]; then
echo "Error: No files were modified when updating changelog"
exit 1
fi
Expand Down Expand Up @@ -95,9 +99,11 @@ jobs:
body: ${{ steps.tag_version.outputs.changelog }}

- name: Build a binary wheel and a source tarball
env:
NEW_TAG: ${{ steps.tag_version.outputs.new_tag }}
run: |
git fetch --tags
git checkout ${{ steps.tag_version.outputs.new_tag }}
git checkout "$NEW_TAG"
uv build --sdist --wheel --out-dir dist/
uv run --extra=release check-wheel-contents dist/*.whl

Expand Down
2 changes: 0 additions & 2 deletions zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,3 @@ rules:
disable: true
superfluous-actions:
disable: true
template-injection:
disable: true
Loading