Move release and tag version into env vars to prevent template injection#2909
Merged
adamtheturtle merged 3 commits intomainfrom Mar 17, 2026
Merged
Move release and tag version into env vars to prevent template injection#2909adamtheturtle merged 3 commits intomainfrom
adamtheturtle merged 3 commits intomainfrom
Conversation
Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Moves
steps.calver.outputs.releaseandsteps.tag_version.outputs.new_taginto environment variables in run/command blocks to prevent template injection, following GitHub's recommended security pattern.See: https://docs.github.com/en/actions/concepts/security/script-injections
Made with Cursor
Note
Medium Risk
Low-code change but touches the release/publish GitHub Actions workflow; mistakes could break tagging, changelog updates, or artifact builds during releases.
Overview
Tightens the
release.ymlworkflow to avoid GitHub Actions expression interpolation inside shell scripts by passing step outputs (e.g., calverrelease, changelogmodifiedFiles, and tagnew_tag) viaenvvariables and referencing them inrunblocks.Updates
zizmor.ymlby removing thetemplate-injectionrule disable, allowing the linter to flag this class of issue going forward.Written by Cursor Bugbot for commit fa2cb9a. This will update automatically on new commits. Configure here.