Skip to content

Move release and tag version into env vars to prevent template injection#2909

Merged
adamtheturtle merged 3 commits intomainfrom
env-vars-release
Mar 17, 2026
Merged

Move release and tag version into env vars to prevent template injection#2909
adamtheturtle merged 3 commits intomainfrom
env-vars-release

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Mar 17, 2026

Moves steps.calver.outputs.release and steps.tag_version.outputs.new_tag into environment variables in run/command blocks to prevent template injection, following GitHub's recommended security pattern.

See: https://docs.github.com/en/actions/concepts/security/script-injections

Made with Cursor


Note

Medium Risk
Low-code change but touches the release/publish GitHub Actions workflow; mistakes could break tagging, changelog updates, or artifact builds during releases.

Overview
Tightens the release.yml workflow to avoid GitHub Actions expression interpolation inside shell scripts by passing step outputs (e.g., calver release, changelog modifiedFiles, and tag new_tag) via env variables and referencing them in run blocks.

Updates zizmor.yml by removing the template-injection rule disable, allowing the linter to flag this class of issue going forward.

Written by Cursor Bugbot for commit fa2cb9a. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@adamtheturtle adamtheturtle merged commit 8a6454c into main Mar 17, 2026
16 checks passed
@adamtheturtle adamtheturtle deleted the env-vars-release branch March 17, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant