Skip to content

Add QueueFactoryProvider#263

Open
vjik wants to merge 2 commits intomasterfrom
queue-factory-provider
Open

Add QueueFactoryProvider#263
vjik wants to merge 2 commits intomasterfrom
queue-factory-provider

Conversation

@vjik
Copy link
Member

@vjik vjik commented Mar 13, 2026

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? ✔️

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.54%. Comparing base (0a3fafd) to head (8243b6e).

Files with missing lines Patch % Lines
src/Provider/QueueFactoryProvider.php 93.75% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
- Coverage     98.71%   98.54%   -0.17%     
- Complexity      350      360      +10     
============================================
  Files            46       47       +1     
  Lines           932      964      +32     
============================================
+ Hits            920      950      +30     
- Misses           12       14       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested review from a team and Copilot March 13, 2026 11:52
@vjik vjik added the status:code review The pull request needs review. label Mar 13, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new QueueFactoryProvider implementation to the queue provider subsystem, allowing queues to be created directly from DI/definition config (via yiisoft/definitions + yiisoft/factory) similarly to the existing adapter-based provider.

Changes:

  • Introduce QueueFactoryProvider that instantiates and caches QueueInterface instances from definitions.
  • Add unit tests covering basic get/has behavior, caching, enum names, container wiring, and invalid configuration handling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Provider/QueueFactoryProvider.php New provider that builds queues from definitions using StrictFactory and normalizes queue names.
tests/Unit/Provider/QueueFactoryProviderTest.php Unit tests validating provider behavior and error cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants