Open
Conversation
Member
vjik
commented
Mar 13, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Tests pass? | ✔️ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
============================================
- Coverage 98.71% 98.54% -0.17%
- Complexity 350 360 +10
============================================
Files 46 47 +1
Lines 932 964 +32
============================================
+ Hits 920 950 +30
- Misses 12 14 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new QueueFactoryProvider implementation to the queue provider subsystem, allowing queues to be created directly from DI/definition config (via yiisoft/definitions + yiisoft/factory) similarly to the existing adapter-based provider.
Changes:
- Introduce
QueueFactoryProviderthat instantiates and cachesQueueInterfaceinstances from definitions. - Add unit tests covering basic get/has behavior, caching, enum names, container wiring, and invalid configuration handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Provider/QueueFactoryProvider.php |
New provider that builds queues from definitions using StrictFactory and normalizes queue names. |
tests/Unit/Provider/QueueFactoryProviderTest.php |
Unit tests validating provider behavior and error cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
samdark
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.