feat: add importOrderSortGroups option#397
Open
coltonb-mixpanel wants to merge 1 commit intotrivago:mainfrom
Open
feat: add importOrderSortGroups option#397coltonb-mixpanel wants to merge 1 commit intotrivago:mainfrom
coltonb-mixpanel wants to merge 1 commit intotrivago:mainfrom
Conversation
coltonb-mixpanel
force-pushed
the
main
branch
from
c4c0ca0 to
613e60c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Introduces the option
importOrderSortGroups(default: true to be non-breaking) which can be disabled to completely disable sorting within specified groups. Added test coverage to thegetSortedNodesGroupmethod for this and the other options as well.Why is this useful?
Most likely an edge case, but for old codebases with a lot of code and hidden side effects embedded in the import order, this makes usage of this plugin feasible.