Support null base revisions in vcs.get_changed_files#921
Merged
ahal merged 2 commits intotaskcluster:mainfrom Mar 16, 2026
Merged
Support null base revisions in vcs.get_changed_files#921ahal merged 2 commits intotaskcluster:mainfrom
ahal merged 2 commits intotaskcluster:mainfrom
Conversation
This case can happen when you push a new branch to Github. Issue: taskcluster#864
bhearsum
approved these changes
Mar 16, 2026
| # When base is NULL_REVISION (e.g new branches on Github), diff | ||
| # from the empty tree to show all files present at rev. Use Git's | ||
| # well-known empty tree hash. | ||
| cmd = ["diff", "4b825dc642cb6eb9a060e54bf8d69288fbee4904", rev] |
Contributor
There was a problem hiding this comment.
TIL about this well known empty tree hash.
Collaborator
Author
There was a problem hiding this comment.
Me too tbh, you can thank Claude. I did verify the hash locally as well as did a search. Using it seems to be fairly common from the looks of things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #864