fix(jwt-bundle): honor jwt-svid use when loading authorities#418
Closed
maxlambrecht wants to merge 1 commit intospiffe:mainfrom
Closed
fix(jwt-bundle): honor jwt-svid use when loading authorities#418maxlambrecht wants to merge 1 commit intospiffe:mainfrom
maxlambrecht wants to merge 1 commit intospiffe:mainfrom
Conversation
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Member
Author
|
Closing this PR. The Per the Workload API spec, FetchJWTBundles already returns JWK Sets for JWT-SVID signing keys, so re-filtering by use in the client path is not appropriate here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enforce SPIFFE bundle semantics for JWT-SVID keys when loading JWT bundles. Only JWKs with use=jwt-svid are treated as JWT authorities, kid remains required for those JWT-SVID keys, and entries for other SVID types or unknown key types are ignored instead of being used as JWT authorities.
Why
Previously, JWT bundle ingestion accepted all EC/RSA JWKs regardless of the use parameter. This could cause incorrect behavior when consuming generic or mixed SPIFFE bundles, where keys for x509-svid or other usages might be present alongside JWT-SVID keys. The SPIFFE JWT-SVID and SPIFFE Bundle specifications require that JWT-SVID signing keys be selected via
use=jwt-svidand that kid be present. Aligning the implementation with these semantics ensures only intended JWT-SVID keys are used for JWT validation and avoids treating other keys as JWT authorities.How tested
Updated
JwtBundleTestto:JwtBundleException