Skip to content

Update typing in Run's __exit__ to match what Python expects #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzscisoft merged 1 commit into from
Mar 23, 2026
Merged

Update typing in Run's __exit__ to match what Python expects #933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions simvue/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import sys
import traceback as tb
import time
import types
import functools
import platform
import typing
Expand Down Expand Up @@ -234,9 +235,9 @@ def __enter__(self) -> Self:

def _handle_exception_throw(
self,
exc_type: typing.Type[BaseException] | None,
value: BaseException,
traceback: typing.Type[BaseException] | BaseException | None,
exc_type: type[BaseException] | None,
value: BaseException | None,
traceback: types.TracebackType | None,
) -> None:
_exception_thrown: str | None = exc_type.__name__ if exc_type else None
_is_running: bool = self._status == "running"
Expand Down Expand Up @@ -272,9 +273,9 @@ def _handle_exception_throw(

def __exit__(
self,
exc_type: typing.Type[BaseException] | None,
value: BaseException,
traceback: typing.Type[BaseException] | BaseException | None,
exc_type: type[BaseException] | None,
value: BaseException | None,
traceback: types.TracebackType | None,
) -> None:
logger.debug(
"Automatically closing run '%s' in status %s",
Expand Down
Loading