Conversation
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Roblox script-capabilities sandboxing to the packaged Purse script container and updates code/docs so runtime-created instances remain inside the sandboxed container.
Changes:
- Parent internal
BindableEvents toscriptso they’re created within the script’s capability sandbox. - Add
models/Purse/init.meta.jsonto enableSandboxedand set theCapabilitiesbitmask for thePurseModuleScript container. - Document capabilities (new
docs/capabilities.md) and add it to the MkDocs nav; adjust guide snippet line references.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/init.luau | Parents BindableEvents to script to keep them within the script capability container. |
| models/Purse/init.meta.json | Configures sandboxing + capability bitmask for the packaged Purse entrypoint script. |
| mkdocs.yml | Adds the new “Capabilities” docs page to navigation. |
| docs/guide.md | Updates snippet line anchors/line numbers to match source shifts. |
| docs/capabilities.md | New documentation describing sandboxing and required capabilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.