fix(revealjs): add aria-label to slide-menu button link#14251
Draft
mcanouil wants to merge 3 commits intoquarto-dev:mainfrom
Draft
fix(revealjs): add aria-label to slide-menu button link#14251mcanouil wants to merge 3 commits intoquarto-dev:mainfrom
mcanouil wants to merge 3 commits intoquarto-dev:mainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mcanouil
removed
bug
mcanouil
force-pushed
the
fix/issue14249
branch
from
536f088 to
bb710a2
Compare
…4249) The bundled reveal.js-menu plugin creates the slide menu button as an anchor element with no text content or aria-label, which fails the axe-core link-name rule (WCAG 2.4.4, Level A). Add aria-label attribute so screen readers announce the link purpose.
The link-name violation from the slide-menu button is now fixed, so remove the revealjs test cases and the unused link-name entry from violationText.
mcanouil
force-pushed
the
fix/issue14249
branch
from
607051c to
96207e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled reveal.js-menu plugin creates the slide menu button as
<a href="#">with no text content oraria-label, failing the axe-corelink-namerule (WCAG 2.4.4, Level A). The upstream plugin repo is archived since the 31st of January 2026), so this fixes the issue directly in Quarto by addingaria-label="Slide menu"to the anchor element.Playwright tests were expected the violation, but as the upstream repository is no longer maintained, if Quarto keeps shipping the plugin, then the fix should be done in Quarto which means the expected violation is no longer necessary in tests.
Closes #14249.