Skip to content

Add flow library target and wire as dep of test_operators#18383

Open
rascani wants to merge 1 commit intopytorch:mainfrom
rascani:export-D97333154
Open

Add flow library target and wire as dep of test_operators#18383
rascani wants to merge 1 commit intopytorch:mainfrom
rascani:export-D97333154

Conversation

@rascani
Copy link
Contributor

@rascani rascani commented Mar 20, 2026

Summary:
The test_operators library target globs all operator test files, but those
files import TestFlow from executorch.backends.test.suite.flow which had
no Buck target owner. This caused listing failures for any downstream
consumer of test_operators.

Add a flow library target in test/suite/BUCK and add it as a dep of
test_operators (migrated from TARGETS to BUCK with fbcode_target).

This diff was authored with Claude.

Differential Revision: D97333154

Summary:
The test_operators library target globs all operator test files, but those
files import TestFlow from executorch.backends.test.suite.flow which had
no Buck target owner. This caused listing failures for any downstream
consumer of test_operators.

Add a flow library target in test/suite/BUCK and add it as a dep of
test_operators (migrated from TARGETS to BUCK with fbcode_target).

This diff was authored with Claude.

Differential Revision: D97333154
@rascani rascani requested a review from cccclai as a code owner March 20, 2026 21:02
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 20, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18383

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 3 Unrelated Failures

As of commit c59e54f with merge base 07b7c7e (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 20, 2026

@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97333154.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani rascani requested a review from GregoryComer March 20, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants