Windows wheels [A]: fix XNNPACK test hang by disabling pthreadpool on Windows#18372
Draft
manuelcandales wants to merge 4 commits intomainfrom
Draft
Windows wheels [A]: fix XNNPACK test hang by disabling pthreadpool on Windows#18372manuelcandales wants to merge 4 commits intomainfrom
manuelcandales wants to merge 4 commits intomainfrom
Conversation
The previous fix (setting sslBackend in pre_build_script.sh) only applied to nested tokenizer submodules. The top-level submodule checkout still used schannel via the reusable workflow's `submodules: true`, causing SEC_E_ILLEGAL_MESSAGE errors when cloning from git.gitlab.arm.com. Move all submodule initialization into the pre-build script where we can control the SSL backend, and disable submodule checkout in the workflow.
Move submodule initialization above the aarch64 sed workaround so the file it edits is guaranteed to exist even if the caller disables submodule checkout. Also remove the redundant UNAME_S assignment later in the script.
The default 60-minute timeout from pytorch/test-infra is too tight for the Windows wheel build + smoke test, causing jobs to be cancelled.
…dows pthreadpool's condvar-based synchronization on Windows can deadlock with multiple threads due to a lost-wakeup bug where signal_num_recruited_threads uses cnd_signal on a condition variable shared between two different wait conditions. Return nullptr from get_pthreadpool() on Windows so XNNPACK runs single-threaded.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18372
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 67b4c8d with merge base 94e9ca6 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
manuelcandales
force-pushed
the
manuel/build-windows-wheels-fix-2
branch
from
8033f32 to
77989a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pthreadpool's condvar-based synchronization on Windows can deadlock with multiple threads due to a lost-wakeup bug where signal_num_recruited_threads uses cnd_signal on a condition variable shared between two different wait conditions. Return nullptr from get_pthreadpool() on Windows so XNNPACK runs single-threaded.