[mypyc] Fix cross-module class attribute defaults causing KeyError#21012
Open
VaggelisD wants to merge 1 commit intopython:masterfrom
Open
[mypyc] Fix cross-module class attribute defaults causing KeyError#21012VaggelisD wants to merge 1 commit intopython:masterfrom
VaggelisD wants to merge 1 commit intopython:masterfrom
Conversation
When mypyc compiles a subclass that inherits class attribute defaults from a parent in a different module, the generated __mypyc_defaults_setup method would look up the parent's module-level variables in the subclass's module globals instead of the parent's, causing KeyError at runtime. Fix by tracking the origin module for each default assignment and using a targeted globals_lookup_module override on the builder when evaluating inherited rvalues. This only affects load_globals_dict, not lambda/closure declarations. Also export each module's globals dict in the export table so cross-group access works in separate compilation mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mypyc compiles a subclass that inherits class attribute defaults from a parent in a different module, the generated
__mypyc_defaults_setupmethod would look that up in the subclass's module globals instead of the parent's, causingKeyErrorat runtime.This PR fixes this by tracking the origin module for each default assignment and using a targeted
globals_lookup_moduleoverride on the builder when evaluating inherited rvalues. This only affectsload_globals_dict, not lambda/closure declarations. Also export each module's globals dict in the export table so cross-group access works in separate compilation mode.