Add WMV (Windows Media Video) support#499
Open
StoneCotton wants to merge 1 commit intop2r3:masterfrom
Open
Conversation
Map WMV to the ASF container format already supported by FFmpeg, with friendly naming, MIME normalization, and a higher encode bitrate (15 Mbps video / 192 kbps audio) suitable for the older WMV codecs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| internal: "asf", | ||
| category: "video" | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
You added CommonFormats.WMV, why not use it?
Ah, I see what's happening here. Admittedly figuring this out myself was a bit difficult too, but FormatDefinition.builder takes a string that is the internal. So CommonFormats.WMV.builder("asf").allowFrom().allowTo() would produce the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for WMV input and output by mapping it to the ASF container
format already handled by FFmpeg.
Changes:
FormatDefinitioninCommonFormats.tsasf→ "Windows Media Video (WMV)" friendly name mapping in FFmpeg handlerinternal: "asf"(same pattern as QTA)video/x-ms-wmv→video/x-ms-asfMIME normalization