Skip to content

Fix installation from source, which missed wombatSetup.js#287

Merged
benoit74 merged 1 commit intomainfrom
git-install
Mar 16, 2026
Merged

Fix installation from source, which missed wombatSetup.js#287
benoit74 merged 1 commit intomainfrom
git-install

Conversation

@benoit74
Copy link
Collaborator

When installing from source code, we do not retrieve wombatSetup.js from source code (this is expected) and we have nothing in the build chain which will build it. We hence need to add it to openzim.toml so that anyone using a dependency like zimscraperlib @ git+https://github.com/openzim/python-scraperlib@main will get a working setup.

This is not expected to have side-effects because it should anyway get "overridden" with proper version in real publication to PyPi.

@benoit74 benoit74 self-assigned this Mar 16, 2026
@benoit74 benoit74 added this to the 5.4.0 milestone Mar 16, 2026
@benoit74
Copy link
Collaborator Author

Nota: downside is that this is still not perfect since we download wombatSetup.js from https://dev.kiwix.org/zimscraperlib/wombatSetup.js, which is the last version built from main scraperlib branch.

Anyone using a dependency like zimscraperlib @ git+https://github.com/openzim/python-scraperlib@my-branch will get every code from my-branch except wombatSetup.js which will still come from main branch code.

I think this downside is very significantly out-weighted by:

  • the fact that it means we still do not need Node.JS to install zimscraperlib
  • the fact that in general wombatSetup.js can be tested in isolation, merged to main and only then tested in client codebases

@benoit74 benoit74 merged commit 8c16fa6 into main Mar 16, 2026
7 checks passed
@benoit74 benoit74 deleted the git-install branch March 16, 2026 22:07
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.52%. Comparing base (ac1fbd9) to head (d679fb1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          41       41           
  Lines        2516     2516           
  Branches      354      354           
=======================================
  Hits         2504     2504           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant