repl: add customizable error handling#62188
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Mar 12, 2026
Merged
Conversation
addaleax
added
the
semver-minor
nodejs-github-bot
added
needs-ci
Whether or not an exception should be handled when it was thrown in the REPL's context but the REPL is already closed is something that will depend on the details of the specific REPL instance's use case. Adding this option lets the REPL's creator control the details of this behavior. This resolves a TODO recently added in bd3cba5.
addaleax
force-pushed
the
repl-handle-errors-fn
branch
from
7aa0e38 to
64670a3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62188 +/- ##
=======================================
Coverage 89.65% 89.66%
=======================================
Files 676 676
Lines 206546 206561 +15
Branches 39558 39552 -6
=======================================
+ Hits 185179 185204 +25
+ Misses 13485 13474 -11
- Partials 7882 7883 +1
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Mar 11, 2026
github-actions
bot
removed
the
request-ci
Collaborator
atlowChemi
approved these changes
Mar 11, 2026
addaleax
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 5e3951e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether or not an exception should be handled when it was thrown in the REPL's context but the REPL is already closed is something that will depend on the details of the specific REPL instance's use case.
Adding this option lets the REPL's creator control the details of this behavior.
This resolves a TODO recently added in bd3cba5.