Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/mcp/server/mcpserver/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@ def __init__(
self._token_verifier = ProviderTokenVerifier(auth_server_provider)
self._custom_starlette_routes: list[Route] = []

# Configure logging
configure_logging(self.settings.log_level)

@property
def name(self) -> str:
return self._lowlevel_server.name
Expand Down Expand Up @@ -278,6 +275,8 @@ def run(
transport: Transport protocol to use ("stdio", "sse", or "streamable-http")
**kwargs: Transport-specific options (see overloads for details)
"""
configure_logging(self.settings.log_level)

TRANSPORTS = Literal["stdio", "sse", "streamable-http"]
if transport not in TRANSPORTS.__args__: # type: ignore # pragma: no cover
raise ValueError(f"Unknown transport: {transport}")
Expand Down
14 changes: 14 additions & 0 deletions tests/server/mcpserver/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -1481,3 +1481,17 @@ async def test_report_progress_passes_related_request_id():
message="halfway",
related_request_id="req-abc-123",
)


def test_init_does_not_configure_logging():
"""MCPServer.__init__ must not call logging.basicConfig or add handlers.

Libraries should never configure the root logger — that is the
application's responsibility. Logging should only be configured
when the server is run as a standalone process via ``run()``.

Regression test for https://github.com/modelcontextprotocol/python-sdk/issues/1656
"""
with patch("mcp.server.mcpserver.server.configure_logging") as mock_configure:
MCPServer("test")
mock_configure.assert_not_called()
Loading