[shimV2] adds vpci device controller#2643
Open
rawahars wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
This change adds the VPCI device controller which can be used to assign/unassign virtual PCI devices to the UVM. The same then can be assigned to the containers running in the UVM. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
jterry75
requested changes
Mar 23, 2026
| defer m.mu.Unlock() | ||
|
|
||
| // Check for an existing assignment with the same device key. | ||
| if existingGUID, ok := m.keyToGUID[key]; ok { |
Contributor
There was a problem hiding this comment.
You have an identity conflict here.
So you either need to allow the caller to specify the guid, and validate that its found settings are the same, or you need to have the caller only specify the host path and vf number and you control the guid. Then you know they match and are associated the same.
| // Since the V2 shims only support WS2025 and later, this is set as true. | ||
| propagateAffinity := true | ||
|
|
||
| settings := hcsschema.VirtualPciDevice{ |
Contributor
There was a problem hiding this comment.
Are you supposed to be making a new device for every function? Or are we supposed to be adding functions to a single device? What controls that answer?
|
|
||
| // addGuestVPCIDevice notifies the guest about the new device and blocks until | ||
| // the required sysfs/device paths are available before workloads use them. | ||
| func (m *Manager) addGuestVPCIDevice(ctx context.Context, vmBusGUID string) error { |
Contributor
There was a problem hiding this comment.
Is this really a guest Add? It seems like it's a "wait guest ready"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds the VPCI device controller which can be used to assign/unassign virtual PCI devices to the UVM. The same then can be assigned to the containers running in the UVM.
Changes
The package exposes a controller that handles the full lifecycle of vPCI device assignments on a UVM. When a device is assigned, the controller issues a host-side HCS call to attach the physical PCI device to the VM. For Linux guests (LCOW), it additionally notifies the GCS so the guest can wait for the required device paths to become available before any workload uses them. For Windows guests (WCOW), no guest-side notification is needed. When a device is removed, the controller tears down the host-side assignment and cleans up all associated state.
Key Design Decisions