fix: move sys.exit(1) inside except block in run_command()#448
Open
mango766 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: move sys.exit(1) inside except block in run_command()#448mango766 wants to merge 1 commit intomicrosoft:mainfrom
mango766 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
sys.exit(1) was at the same indentation as the try block, so it ran unconditionally after subprocess.run() — even on success. This caused the setup pipeline and benchmarks to always exit with code 1 after the first command without a log_step. Indent it into the except block to match the log_step branch above.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #447
sys.exit(1)was outside theexceptblock due to indentation, so it ran unconditionally aftersubprocess.run()— even when the command succeeded. This caused the setup pipeline and benchmarks to always exit with code 1 after the first command that runs without alog_step.The
log_stepbranch (with log file) already has the correct indentation. This just aligns theelsebranch to match.Files changed:
setup_env.py— line 107utils/e2e_benchmark.py— line 23