TPT-4206: Integration tests for NB Front-End IP & 40Gbps

[mawilk90]

📝 Description

Integration tests for NodeBalancer Front-End IP in VPC and 40Gbps NodeBalancer-MTC

NOTE:
There is no valid region on DevCloud to create nodebalancers of type=premium_40gb so one test will fail. I decided to do not add 'skipif' dependent on the env, because we usually do not execute tests on DevCloud

✔️ How to Test

make test-int TEST_SUITE=nodebalancer TEST_ARGS="-k test_nb_with"

[Copilot]

Pull request overview

Adds integration coverage for NodeBalancer Front-End IP behavior in VPCs (including single-stack IPv4) and validates the premium_40gb NodeBalancer type behavior.

Changes:

• Added NodeBalancer integration tests for backend-only VPC attachment, frontend VPC IP assignment, and mixed frontend/backend VPC configurations.
• Added new VPC fixtures for IPv4-only VPC/subnet creation to support single-stack frontend tests.
• Updated VPC fixture region capability selection to include additional capabilities needed by the new NodeBalancer/VPC scenarios.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
test/integration/models/nodebalancer/test_nodebalancer.py	Adds new integration tests covering frontend VPC IP assignment and premium 40Gbps type behavior.
test/integration/conftest.py	Expands region capability requirements for VPC fixture and introduces IPv4-only VPC/subnet fixtures used by the new tests.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ezilber-akamai]

Tests pass locally other than the occasional

[400] The selected region does not have any availability for the requested NodeBalancer.

error. Once that is resolved I will approve.

[mawilk90]

Hi @psnoch-akamai , @ezilber-akamai
The reason of instability of some tests is that premium/premium_40gb nodebalancers cannot be created in all the regions. AFAIK from the nodebalancer's team, there is no option to get only the valid regions for premium nodebalancers at the moment (capabilities are not enough) so I decided to hardcode valid region names in the test file + add dedicated fixture and filtering in "get_region" method. If you find that solution overcomplicated, pls let me know.

[ezilber-akamai]

Hi @psnoch-akamai , @ezilber-akamai The reason of instability of some tests is that premium/premium_40gb nodebalancers cannot be created in all the regions. AFAIK from the nodebalancer's team, there is no option to get only the valid regions for premium nodebalancers at the moment (capabilities are not enough) so I decided to hardcode valid region names in the test file + add dedicated fixture and filtering in "get_region" method. If you find that solution overcomplicated, pls let me know.

I think this is quite elegant given the circumstances 👍

Edit: I got [400] The selected region does not have any availability for the requested NodeBalancer. the first time I ran the tests after pulling down the latest commit

Edit 2: Ran the test a bunch more times, it fails infrequently but I did get it to fail more than once. We could consider hard coding one working region for now and adding a TODO to fix that once this is more generally available.

[dawiddzhafarov]

I'm also getting such errors quite consistently:

test/integration/conftest.py:126: in get_region
    return random.choice(regions)
           ^^^^^^^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <random.Random object at 0x13a878e20>, seq = []

    def choice(self, seq):
        """Choose a random element from a non-empty sequence."""
    
        # As an accommodation for NumPy, we don't use "if not seq"
        # because bool(numpy.array()) raises a ValueError.
        if not len(seq):
>           raise IndexError('Cannot choose from an empty sequence')
E           IndexError: Cannot choose from an empty sequence

[dawiddzhafarov]

Once the correct tags are used, tests are passing!

[psnoch-akamai]

All my notes discussed during Webex call. Good job!