controller: block Gateway deletion when AccessPolicy targets it#160
Conversation
Signed-off-by: Harshitha MS <harshitha.ms@ibm.com>
✅ Deploy Preview for kube-agentic-networking ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HarshithaMS005 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @HarshithaMS005. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Deleting a Gateway that is still referenced by an AccessPolicy can lead to inconsistent state and reconciliation errors.
targetRefto this Gateway (groupgateway.networking.k8s.io, kindGateway). If so, the Gateway’s finalizer is not removed and the Envoy proxy is not deleted until those AccessPolicies are removed.targetRefs. So when an AccessPolicy that targeted a Gateway is deleted, the Gateway is reconciled and can then remove its finalizer and complete deletion, avoiding the deadlock pattern.Which issue(s) this PR fixes:
Fixes #150
Does this PR introduce a user-facing change?: