feat(gooddata-sdk): add CatalogAppearanceService for themes and color palettes#1412
Open
hkad98 wants to merge 1 commit intogooddata:masterfrom
Open
feat(gooddata-sdk): add CatalogAppearanceService for themes and color palettes#1412hkad98 wants to merge 1 commit intogooddata:masterfrom
hkad98 wants to merge 1 commit intogooddata:masterfrom
Conversation
…palette management Add sdk.catalog_appearance with CRUD operations (list, get, create, update, delete) for themes and color palettes via the AppearanceApi. Follows the existing service-based facade pattern. The API already exposed these endpoints but the SDK had no wrapper. jira: trivial risk: low
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
- Coverage 77.45% 77.36% -0.09%
==========================================
Files 225 228 +3
Lines 14661 14775 +114
==========================================
+ Hits 11355 11430 +75
- Misses 3306 3345 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CatalogAppearanceServiceexposing theme and color palette CRUD viasdk.catalog_appearanceCatalogTheme,CatalogThemeAttributes,CatalogColorPalette,CatalogColorPaletteAttributesAppearanceApithroughGoodDataApiClientand expose the service onGoodDataSdkThe GoodData API already exposed these endpoints via
AppearanceApi, but the SDK service layer had no wrapper — users had to drop down to the raw API client. This follows the existing service-based facade pattern (matchingCatalogOrganizationService).