feat(core): Support embedding APIs in google-genai#19797
Open
nicohrubec wants to merge 10 commits intodevelopfrom
Open
feat(core): Support embedding APIs in google-genai#19797nicohrubec wants to merge 10 commits intodevelopfrom
nicohrubec wants to merge 10 commits intodevelopfrom
Conversation
nicohrubec
changed the title
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
nicohrubec
commented
Mar 13, 2026
| * Extract model from parameters or chat context object | ||
| * For chat instances, the model is available on the chat object as 'model' (older versions) or 'modelVersion' (newer versions) | ||
| */ | ||
| export function extractModel(params: Record<string, unknown>, context?: unknown): string { |
Member
Author
There was a problem hiding this comment.
from here on these functions were just moved to utils to make the linter happy
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instrumentation support for the Google GenAI embeddings API (
models.embedContent).Closes #19535