Skip to content

feat(baggage): Added double baggage prevention logic#19597

Draft
harshit078 wants to merge 12 commits intogetsentry:developfrom
harshit078:baggage-sent-twice
Draft

feat(baggage): Added double baggage prevention logic#19597
harshit078 wants to merge 12 commits intogetsentry:developfrom
harshit078:baggage-sent-twice

Conversation

@harshit078
Copy link
Contributor

@harshit078 harshit078 commented Mar 3, 2026

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes #19158

@Lms24
Copy link
Member

Lms24 commented Mar 13, 2026

Hey @harshit078 thanks for taking over the issue and opening the PR! I see there are some tests failing regarding the mergeBaggageHeaders function. Are you aware of this and looking into fixing it or should we take over? Just let me know :)

There's one test named "overwrites existing Sentry entries with new ones", so I'm wondering why we'd end up with duplicated entries. This might be related to #17355 which got merged yesterday.

@harshit078
Copy link
Contributor Author

Hey @Lms24 , yes I am resolving the current failing tests and pushing a fix for it. I'll mark the PR as ready to review as soon as all tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

baggage is sent twice when tracesSampleRate is set and Sentry.getTraceData() is added manually

2 participants