test(cache): [Cache Tracing 23] Add missing cache key assertions and use exact equals#5228
Merged
adinauer merged 2 commits intofeat/cache-tracingfrom Mar 23, 2026
Merged
Conversation
This was referenced Mar 23, 2026
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Spring
Other
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Sentry Build Distribution
|
Base automatically changed from
fix/cache-tracing-evict-system-test
to
feat/cache-tracing
March 23, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Cache Tracing)
📜 Description
CACHE_KEYassertions to wrapper tests across all three Spring modules (spring, jakarta, spring-7) for operations that use a key but were not verifying it: get (hit/miss), get-with-type (hit/miss), get-with-callable (hit/miss), retrieve (hit/miss/null), retrieve-with-loader (hit/miss), evict, evictIfPresentArrays.asListwithCollections.singletonListin all four production wrapper files for single-key spans — immutable, no backing array allocation, communicates single-element intentcontains/containsAllassertions in JCache multi-key tests (getAll, putAll, removeAll) with exactassertEqualschecks on bothdescriptionandCACHE_KEY