Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the material, it is stated that hot reload might not work when running a React development server inside a docker container and making changes to bind mounted files on host machine. At least on my computer, even manually reloading the app on the browser did not make the changes visible. Apparently there is an issue related to the WSL2. microsoft/WSL#6255 (comment)
However the problem can be solved, at least on my computer, by adding environment-variable "WATCHPACK_POLLING=true" on the docker-compose.yml. After adding this to the compose-configuration, even hot reload started to work as expected.
This information should be added to the material so that each student does not have to spend hours figuring it out individually.