Update contributing guidelines and the PR template#9700
Update contributing guidelines and the PR template#9700elliette wants to merge 5 commits intoflutter:masterfrom
Conversation
elliette
requested review from
bkonyi,
kenzieschmoll and
srawlins
and removed request for
a team and
bkonyi
srawlins
left a comment
srawlins
left a comment
There was a problem hiding this comment.
This is all great! Very readable text changes.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| ### Tests checklist | ||
|
|
||
| - [ ] I added new tests to check the change I am making... | ||
| - [ ] OR there is a reason for not adding tests. |
There was a problem hiding this comment.
| - [ ] OR there is a reason for not adding tests. | |
| - [ ] OR there is a reason for not adding tests. If this is the case, please explain why in the PR description. |
| - [ ] I added new tests to check the change I am making... | ||
| - [ ] OR there is a reason for not adding tests. | ||
|
|
||
| ### AI-tooling checklist |
There was a problem hiding this comment.
@stuartmorgan-g do you have any feedback on this section?
There was a problem hiding this comment.
It looks like the specific elements that are pulled out from the guidelines to be their own extra checkbox items here (which I think has the effect of emphasizing those things, and thus de-emphasizing the rest) are all one-time things that apply to creating the initial PR. They commit to having reviewed the code before opening the PR, but aren't committing to reviewing future AI generated changes. They commit to having verified the accuracy of the PR description, but aren't committing to verifying the accuracy of future comments.
We've had non-trivial issues with people who feed review comments into an AI and uncritically upload the results—both code and response comments—either manually or by pointing an agent at the PR. Given that, I would worry that people would come away from this checklist thinking that basic due diligence on AI output is a one-time thing rather than an ongoing process. But you may be seeing different patterns of behavior in this repository, and want to emphasize different things as a result.
6 participants
No description provided.