Conversation
josevalim
commented
Mar 16, 2026
_posts/2026-03-19-lazy-bdds-with-eager-literal-differences.markdown
Outdated
Show resolved
Hide resolved
jeregrine
reviewed
Mar 16, 2026
| you know `clause3` is redundant if: | ||
|
|
||
| ``` | ||
| clause3 ⊆ (clause1 ∪ clause2) |
There was a problem hiding this comment.
you probably want to define the subset/unions characters here been a while since most of us have worked with them (long while for me lol)
jeregrine
reviewed
Mar 16, 2026
| have the same type, except for one. For example: | ||
|
|
||
| ``` | ||
| def example(%MyStruct{x: x}) when is_binary(x) |
There was a problem hiding this comment.
I know we're focusing on backwards compatible changes but if MyStruct x is a binary or integer I think I might have messed up my structure definition lol.
There was a problem hiding this comment.
maybe an is_nil would be more common example
Member
Author
There was a problem hiding this comment.
This is a field in the structure, no? They can be binary or integer, that's fine! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.