compiler: Tweak use of degenerating_indices when determining iteration directions#2873
Merged
compiler: Tweak use of degenerating_indices when determining iteration directions#2873
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
=======================================
Coverage 79.05% 79.06%
=======================================
Files 248 248
Lines 51252 51276 +24
Branches 4428 4431 +3
=======================================
+ Hits 40518 40539 +21
- Misses 9924 9927 +3
Partials 810 810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| super().__init__(*args) | ||
|
|
||
| # Register the cached type | ||
| # Register the cached type and eagerly create its cache, bound to its |
Contributor
Author
There was a problem hiding this comment.
This was a Claude fix 😅 LogicalDependence objects kept getting constructed as Dependence objects due to the caching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweaking the logic for treatment of degenerating indices created through
Buffer(1)made the time loop direction default to forward in setups where it shouldn't. This hotfix should correct this behaviour and introduces additional checks for this.