Merged
Conversation
- Updated the precheck command to replace the --disable-lvs flag with --skip-checks for better flexibility in skipping specific checks. - Added a new --magic-drc flag to include optional Magic DRC checks. - Simplified Docker image handling in the setup process, ensuring clearer error messages if Docker is not found. - Enhanced test cases to reflect changes in command options and validate new functionality.
…t handling - Replaced direct command-line arguments with a precheck_args list for better readability and maintainability. - Updated Docker command to execute the precheck using a pip-installed script, enhancing flexibility. - Retained existing functionality for magic DRC and skip checks options while streamlining the command structure.
- Updated the setup process to install the cf-precheck Python package instead of pulling a Docker image, improving installation flexibility. - Added version display for the installed cf-precheck package to provide user feedback. - Implemented a check for Docker image updates before running the precheck command, ensuring the latest image is used. - Streamlined argument handling for the precheck command, maintaining support for magic DRC and skip checks options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.