Skip to content

ci: use GitHub App token in integration-tests workflow#100

Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intomainfrom
abhi-fix-integration-pr-workflow
Mar 19, 2026
Merged

ci: use GitHub App token in integration-tests workflow#100
Abhijeet Prasad (AbhiPrasad) merged 2 commits intomainfrom
abhi-fix-integration-pr-workflow

Conversation

@AbhiPrasad
Copy link
Member

Using the run-integration-tests label was failing in #99. This fixes that.

@AbhiPrasad Abhijeet Prasad (AbhiPrasad) changed the title fix: use GitHub App token in integration-tests workflow ci: use GitHub App token in integration-tests workflow Mar 19, 2026
@viadezo1er
Copy link
Contributor

ViaDézo1er / cedric (viadezo1er) commented Mar 19, 2026

After commenting if: ${{ contains(github.event.pull_request.labels.*.name, 'run-integration-tests') }}, ran
act --container-daemon-socket /var/run/docker.sock -W integration-tests.yaml
act is a tool to run Github actions locally
The --container-daemon-socket /var/run/docker.sock is needed because I use colima to have docker, otherwise might not be needed.

Anyway, it fails with:

[integration-tests/open-pr]   🐳  docker exec cmd=[/usr/local/bin/node /var/run/act/actions/actions-create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859/dist/main.cjs] user= workdir=
| Inputs 'owner' and 'repositories' are set. Creating token for the following repositories:
|       
| - braintrustdata/braintrust
| - braintrustdata/braintrust-sdk-python
| Error: [@octokit/auth-app] appId option is required
|     at createAppAuth (/run/act/actions/actions-create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859/dist/main.cjs:22899:11)
|     at main (/run/act/actions/actions-create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859/dist/main.cjs:23190:17)
|     at run (/run/act/actions/actions-create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859/dist/main.cjs:23316:10)
|     at Object.<anonymous> (/run/act/actions/actions-create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859/dist/main.cjs:23328:20)
|     at Module._compile (node:internal/modules/cjs/loader:1521:14)
|     at Module._extensions..js (node:internal/modules/cjs/loader:1623:10)
|     at Module.load (node:internal/modules/cjs/loader:1266:32)
|     at Module._load (node:internal/modules/cjs/loader:1091:12)
|     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:164:12)
|     at node:internal/main/run_main_module:28:49
[integration-tests/open-pr]   ❗  ::error::[@octokit/auth-app] appId option is required

It might be a local issue because this isn't a real Github action, or might mean the new workflow is broken.
If I'm not mistaken the job got skipped after your commit, ergo so far this workflow has never been run 'for real'.

Could you do a canary release or something to trigger the workflow on the real github runner?

@viadezo1er
Copy link
Contributor

Wait I think I can do a canary release?

@AbhiPrasad
Copy link
Member Author

A canary release won’t do anything - this is for the workflow of adding the label.

I added one, but it’s using the workflow from main so still failing.

We have an identical workflow in the JavaScript repo, it recently was updated to use the same logic as we now have here. Given it works in the other repo, I think we can try it here too. Unfortunately until we merge there’s no good way to test this. act does not suffice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it then

@AbhiPrasad Abhijeet Prasad (AbhiPrasad) merged commit 98aa3e6 into main Mar 19, 2026
2 of 3 checks passed
@AbhiPrasad Abhijeet Prasad (AbhiPrasad) deleted the abhi-fix-integration-pr-workflow branch March 19, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants