support openai responses endpoint#46
Conversation
Andrew Kent (realark)
force-pushed
the
ark/oai-inst-refactor
branch
7 times, most recently
from
23e13d1 to
00c5a9c
Compare
| clazz = clazz.getSuperclass(); | ||
| } | ||
| } | ||
| throw new NoSuchFieldException(fieldName); |
There was a problem hiding this comment.
the instrumentation impl between the oai and anthropic clients are very similar. I might refactor out some of the internals into common components later (think if this pattern repeats another time I'll do it then).
Andrew Kent (realark)
force-pushed
the
ark/oai-inst-refactor
branch
from
1e38e47 to
b6e390d
Compare
src/main/java/dev/braintrust/instrumentation/openai/TracingHttpClient.java
Outdated
Show resolved
Hide resolved
Andrew Kent (realark)
force-pushed
the
ark/oai-inst-refactor
branch
from
b6e390d to
6bca111
Compare
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
It would be nice if we moved some of the constants like braintrust.metadata into string constants that can be shared more widely, but that is just a nit.
| } | ||
|
|
||
| private static void instrumentHttpClient(OpenTelemetry openTelemetry, AnthropicClient client) { | ||
| forAllFields( |
There was a problem hiding this comment.
I wonder if we can avoid having to iterate through every field, but I don't know enough about java reflection to suggest a proper improvement.
There was a problem hiding this comment.
I think this approach is the most future proof way given how the library is implemented, but I'll keep an eye on this and revisit if my assumption is wrong
Andrew Kent (realark)
force-pushed
the
ark/oai-inst-refactor
branch
from
6bca111 to
f3b9de8
Compare
2 participants
Uh oh!
There was an error while loading. Please reload this page.