Enforce use of 1.0.0-rc.1 payjoin version#252
Open
nymius wants to merge 1 commit intobitcoindevkit:masterfrom
Open
Enforce use of 1.0.0-rc.1 payjoin version#252nymius wants to merge 1 commit intobitcoindevkit:masterfrom
1.0.0-rc.1 payjoin version#252nymius wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
…=1.0.0-rc.1` Cargo's version resolution always updates to the latest patch version. If that patch introduces breaking changes, it breaks your application. This happened after Payjoin released version 1.0.0-rc.2. Because the version specified for bdk-cli was 1.0.0-rc.1, a fresh install automatically updated to the newer patch. To resolve this without migrating to the latest Payjoin API, and to prevent future breakages from subsequent 1.0.0-rc.x releases, this commit pins the Payjoin version strictly to =1.0.0-rc.1.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 10.86% 10.86%
=======================================
Files 8 8
Lines 2466 2466
=======================================
Hits 268 268
Misses 2198 2198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cargo's version resolution always updates to the latest patch version. If that patch introduces breaking changes, it breaks your application.
This happened after Payjoin released version 1.0.0-rc.2. Because the version specified for bdk-cli was 1.0.0-rc.1, a fresh install automatically updated to the newer patch.
To resolve this without migrating to the latest Payjoin API, and to prevent future breakages from subsequent 1.0.0-rc.x releases, this commit pins the Payjoin version strictly to =1.0.0-rc.1.
This happened before in another project: rust-bitcoin/rust-bitcoin#5358
Changelog notice