chore: improve CLAUDE.md with architecture docs and add Claude automations#7
Open
danielbodnar wants to merge 1 commit intomainfrom
Open
chore: improve CLAUDE.md with architecture docs and add Claude automations#7danielbodnar wants to merge 1 commit intomainfrom
danielbodnar wants to merge 1 commit intomainfrom
Conversation
…ns, fix clippy warnings Rewrite CLAUDE.md to document the 5-layer architecture, CLI/TUI dual entry point, provider abstraction, config system, and current project state so new sessions can be productive immediately. Add Claude Code automations: skills (check, test-scaffold), subagents (security-reviewer, clippy-reviewer), context7 MCP server, and hooks for auto-formatting and sensitive file protection. Fix clippy warnings: remove unused imports (StatusCode, error, Path, ProviderType, ProviderCredentials, VolumeStatus, InstanceNetwork, Context, Utc, fs) and unused mut bindings across api/, config/, services/, and main.rs.
There was a problem hiding this comment.
Pull request overview
Updates repository guidance and Claude Code automation to reflect the current bbctl architecture, while also cleaning up Rust clippy warnings (unused imports / unnecessary mut) across several modules.
Changes:
- Rewrote
CLAUDE.mdwith a 5-layer architecture description, entrypoint patterns, and current project state. - Added Claude Code automations (skills, reviewer agents) and MCP server config.
- Removed unused imports / unnecessary mutable bindings in
api/,config/,services/, andmain.rs.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/volume.rs | Removes unused model imports to resolve clippy warnings. |
| src/services/provider.rs | Cleans unused imports and unnecessary mut bindings in provider registration helpers. |
| src/services/instance.rs | Removes unused imports and unnecessary mut bindings for VyOS client usage. |
| src/main.rs | Cleans unused pattern bindings and simplifies an Option presence check. |
| src/config/settings.rs | Removes unused imports and narrows log imports to used macros. |
| src/config/provider.rs | Fixes unused closure variable warning in provider existence check. |
| src/config/mod.rs | Removes unused Path import and narrows log imports. |
| src/config/credentials.rs | Removes unused imports and narrows log imports. |
| src/api/vyos.rs | Removes unused StatusCode import. |
| src/api/proxmox.rs | Removes unused StatusCode and error log import. |
| CLAUDE.md | Adds/updates architecture + workflow documentation for Claude Code usage. |
| .mcp.json | Adds MCP server configuration (context7). |
| .claude/skills/test-scaffold.md | Adds a skill to scaffold Rust tests using repo dev-dependencies. |
| .claude/skills/check.md | Adds a skill to run fmt/clippy/check sequentially. |
| .claude/agents/security-reviewer.md | Adds a security-focused reviewer agent definition. |
| .claude/agents/clippy-reviewer.md | Adds a clippy-focused reviewer agent definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `get_vyos_client()` / `get_proxmox_client()` instantiate typed clients from stored config + credentials | ||
| - `add_vyos_provider()` / `add_proxmox_provider_with_token()` register new providers | ||
|
|
||
| `InstanceService`, `VolumeService`, `NetworkService` each hold in-memory storage (`HashMap<Uuid, T>`) plus a `ProviderService` reference. |
| "mcpServers": { | ||
| "context7": { | ||
| "command": "npx", | ||
| "args": ["-y", "@upstash/context7-mcp@latest"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/check,/test-scaffold), subagents (security-reviewer, clippy-reviewer), context7 MCP server, and hooks for auto-formatting and sensitive file protectionTest plan
cargo buildsucceeds with no warningscargo clippypasses clean