EC: Validate local EC domain parameters for MQV key agreement#2272
Open
Joowon-Seo wants to merge 2 commits intobcgit:mainfrom
Open
EC: Validate local EC domain parameters for MQV key agreement#2272Joowon-Seo wants to merge 2 commits intobcgit:mainfrom
Joowon-Seo wants to merge 2 commits intobcgit:mainfrom
Conversation
Ensure static and ephemeral EC keys used during MQV initialization share the same domain parameters and fail early if they differ. Add tests for matching and mismatched curve scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation during MQV key agreement initialisation to ensure
the local static and ephemeral EC keys share the same domain parameters.
Previously these parameters were not explicitly validated, allowing
mismatched keys to proceed until later stages of the agreement.
Tests added for matching and mismatched curve scenarios.