Fix executor switch detection in UpdateTask#513
Merged
Conversation
The executor change arrives via UpdateTask() which sets m.task directly. By the time Refresh() runs, prevTask already has the new executor, so the change was never detected. Move the detection to UpdateTask() where we can compare the old and new task executor fields. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What was happening
The executor change arrives via
UpdateTask()which setsm.taskdirectly. By the timeRefresh()runs,prevTaskalready has the new executor value, so the change was never detected — the old executor's pane stayed running with just a title change.Fix
Move the executor change detection from
Refresh()toUpdateTask(), where we still have the old task to compare against.Test plan
golangci-lintclean🤖 Generated with Claude Code