Skip to content

Add resourceUrlPattern support to CloudFrontUtilities.getCookiesForCustomPolicy#6779

Open
alextwoods wants to merge 1 commit intomasterfrom
alexwoo/cloudfront_cookie_resourcePattern
Open

Add resourceUrlPattern support to CloudFrontUtilities.getCookiesForCustomPolicy#6779
alextwoods wants to merge 1 commit intomasterfrom
alexwoo/cloudfront_cookie_resourcePattern

Conversation

@alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Mar 11, 2026

Add resourceUrlPattern support to CloudFrontUtilities.getCookiesForCustomPolicy

Fixes: #6127

Motivation and Context

CloudFrontUtilities.getCookiesForCustomPolicy was missing support for resourceUrlPattern. resourceUrlPattern was already supported in getSignedUrlWithCustomPolicy. resourceUrlPatterns should be supported in both, see:

Modifications

  • Mimic the logic from getSignedUrlWithCustomPolicy in getCookiesForCustomPolicy.

Testing

New and existing unit and integration tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner March 11, 2026 17:24
@alextwoods alextwoods added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Mar 11, 2026
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
52.2% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@alextwoods alextwoods added this pull request to the merge queue Mar 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2026
@alextwoods alextwoods added this pull request to the merge queue Mar 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CustomSignerRequest lacks support for resourceUrlPattern in signed cookie policy

2 participants