temporary scripts for branch maintenance by borinquenkid · Pull Request #15488 · apache/grails-core

borinquenkid · 2026-03-09T01:43:09Z

Two tasks one to protect the release branches and another to delete stale branches

Copilot

Pull request overview

Adds Gradle-invokable maintenance automation for GitHub branch hygiene in apache/grails-core (protect release branches, delete stale branches) via two Groovy scripts executed from the root build.gradle.

Changes:

Registers two new Gradle maintenance tasks: deleteBranches and protectBranches.
Introduces ProtectBranches.groovy to apply GitHub branch protection to a curated list of release branches.
Introduces DeleteBranches.groovy to delete a curated list of merged/closed branches via the GitHub API.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 8 comments.

File	Description
build.gradle	Adds Gradle tasks that execute the maintenance Groovy scripts via `GroovyShell`.
ProtectBranches.groovy	New script that calls GitHub’s branch protection API for listed branches.
DeleteBranches.groovy	New script that calls GitHub’s refs API to delete listed branches.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ProtectBranches.groovy

DeleteBranches.groovy

ProtectBranches.groovy

DeleteBranches.groovy

ProtectBranches.groovy

DeleteBranches.groovy

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ProtectBranches.groovy

DeleteBranches.groovy

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

DeleteBranches.groovy

ProtectBranches.groovy

DeleteBranches.groovy

ProtectBranches.groovy

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ProtectBranches.groovy

DeleteBranches.groovy

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ProtectBranches.groovy

DeleteBranches.groovy

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ProtectBranches.groovy

Copilot · 2026-03-09T18:21:17Z

DeleteBranches.groovy

+def githubToken = System.getenv('GITHUB_TOKEN') ?: System.getProperty('github.token')
+def repoOwner   = "apache"
+def repoName    = "grails-core"
+def baseApiUrl  = "https://api.github.com/repos/${repoOwner}/${repoName}"


The target repository is hardcoded to apache/grails-core. That makes it easy to accidentally run this from a fork/clone and still delete branches on the upstream repo if the token has access. Make repoOwner/repoName configurable (env/Gradle properties) and/or require an explicit confirmation that prints the resolved target before proceeding.

DeleteBranches.groovy

ProtectBranches.groovy

jdaugherty · 2026-03-11T12:00:15Z

It's my understanding that the protection logic can't be updated by us. We have to use .asf.yaml to set the protection. The issue is the asf.yaml process hasn't historically supported regex based protection rules - only specific branches. The reason for this is because the rest api does not support setting up this type of protections. Only the graphql library supports this. Have you researched this? Does asf.yaml still have this limitation? Maybe we could contribute to the ASF implementation to get this support so we can then define these in .asf.yaml.

…l not fail the script

testlens-app · 2026-03-11T13:43:22Z

The TestLens GitHub App is installed in this repository but TestLens is currently in private beta.

Please contact us to finish onboarding this repository.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T13:51:46Z

ProtectBranches.groovy

+        if (body) {
+            conn.doOutput = true
+            conn.setRequestProperty("Content-Type", "application/json")
+            conn.outputStream.withWriter { it << body }
+        }
+
+        if (conn.responseCode in [200, 201, 204]) {
+            println "SUCCESS: ${conn.responseCode}"
+        } else {
+            def errorText = conn.errorStream?.text ?: "No error stream available"
+            throw new RuntimeException("HTTP ${conn.responseCode} - ${errorText}")
+        }
+    } finally {
+        conn?.disconnect()
+    }


The response/error streams are never explicitly closed. With HttpURLConnection, leaving streams unclosed can leak resources and (in some JVMs) prevent clean connection teardown. Ensure input/error streams are read/closed (e.g., withCloseable) on both success and failure paths.

Copilot · 2026-03-11T13:51:46Z

DeleteBranches.groovy

+        if (body) {
+            conn.doOutput = true
+            conn.setRequestProperty("Content-Type", "application/json")
+            conn.outputStream.withWriter { it << body }
+        }
+
+        if (conn.responseCode in [200, 201, 204]) {
+            println "SUCCESS: ${conn.responseCode}"
+        } else {
+            def errorText = conn.errorStream?.text ?: "No error stream available"
+            throw new RuntimeException("HTTP ${conn.responseCode} - ${errorText}")
+        }
+    } finally {
+        conn?.disconnect()
+    }


Same as ProtectBranches.groovy: response/error streams aren’t explicitly closed. Close streams deterministically to avoid resource leaks and make failure modes more reliable.

Copilot · 2026-03-11T13:51:46Z

ProtectBranches.groovy

+if (!githubToken || githubToken == "YOUR_PERSONAL_ACCESS_TOKEN") {
+    throw new IllegalStateException(
+        "GitHub token is required. Set the GITHUB_TOKEN environment variable or the -Dgithub.token system property."
+    )
+}


The sentinel check against \"YOUR_PERSONAL_ACCESS_TOKEN\" looks like leftover scaffolding and is inconsistent with DeleteBranches.groovy (which only checks for presence). Either document the expected placeholder usage or remove this special-case to keep behavior consistent and predictable.

temporary scripts for branch maintenance

b56d014

borinquenkid requested review from Copilot and jdaugherty March 9, 2026 01:43

github-project-automation bot added this to Apache Grails Mar 9, 2026

Copilot started reviewing on behalf of borinquenkid March 9, 2026 01:43 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

borinquenkid and others added 7 commits March 8, 2026 20:51

ASL

53ebfc2

Update ProtectBranches.groovy

6f429c4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update DeleteBranches.groovy

090a103

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ProtectBranches.groovy

b43da02

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update DeleteBranches.groovy

2b807a4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ProtectBranches.groovy

96b6f7a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix PR comments

1ffc7bb

borinquenkid requested a review from Copilot March 9, 2026 01:58

Copilot started reviewing on behalf of borinquenkid March 9, 2026 01:59 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

ProtectBranches.groovy Outdated Show resolved Hide resolved

DeleteBranches.groovy Outdated Show resolved Hide resolved

DeleteBranches.groovy Show resolved Hide resolved

borinquenkid and others added 3 commits March 8, 2026 21:03

Update ProtectBranches.groovy

c82b35a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update DeleteBranches.groovy

3f73539

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

more fix PR comments

81d9d19

borinquenkid requested a review from Copilot March 9, 2026 02:07

Copilot started reviewing on behalf of borinquenkid March 9, 2026 02:08 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

borinquenkid and others added 7 commits March 9, 2026 07:38

Update DeleteBranches.groovy

1614fd7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ProtectBranches.groovy

21ff471

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ProtectBranches.groovy

9fd7b84

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ProtectBranches.groovy

dba1910

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update DeleteBranches.groovy

8bad7a6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ProtectBranches.groovy

44d8a6e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

more fix PR comments

a593ce8

borinquenkid requested a review from Copilot March 9, 2026 12:44

Copilot AI reviewed Mar 9, 2026

View reviewed changes

ProtectBranches.groovy Outdated Show resolved Hide resolved

DeleteBranches.groovy Show resolved Hide resolved

Copilot started reviewing on behalf of borinquenkid March 9, 2026 12:56 View session

more PR comments

37535a2

borinquenkid requested a review from Copilot March 9, 2026 17:51

Copilot started reviewing on behalf of borinquenkid March 9, 2026 17:53 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

ProtectBranches.groovy Outdated Show resolved Hide resolved

DeleteBranches.groovy Show resolved Hide resolved

more PR comments

268419b

borinquenkid requested a review from Copilot March 9, 2026 18:16

Copilot started reviewing on behalf of borinquenkid March 9, 2026 18:17 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

pivoted to asf.yml and delete of a branch that is already deleted wil…

8f6e555

…l not fail the script

borinquenkid requested a review from Copilot March 11, 2026 13:43

Copilot started reviewing on behalf of borinquenkid March 11, 2026 13:50 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Uh oh!

Conversation

borinquenkid commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jdaugherty commented Mar 11, 2026

Uh oh!

testlens-app bot commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone