Update datafusion dependency to 52.3.0#1425
Update datafusion dependency to 52.3.0#1425timsaucer wants to merge 3 commits intoapache:branch-52from
Conversation
|
|
||
| // Re-export Apache Arrow DataFusion dependencies | ||
| pub use datafusion; | ||
| pub use datafusion::{ |
There was a problem hiding this comment.
nit: ive been seeing a lot of these changes across PRs, is there something we can run for the entire repo? or configure the linter?
There was a problem hiding this comment.
It's a change in the nightly cargo fmt, probably from the new rust release. If we do, then we'd need to turn off the group_imports and imports_granularity in rustfmt.toml. I suppose we could do that and just have it turned on in the pre-commit. That just means that any contributors who do have that turned on will end up with more formatting changes than others. Or we could take those out, but personally I think it does make the repo cleaner. What do you think?
There was a problem hiding this comment.
ah its already part of pre-commit (we're using cargo +nightly fmt) here
I see the change is already applied in the main branch.
We're seeing this change again because this PR targets the apache:branch-52 branch.
Ignore my comment 😄 everything looks good
2 participants
Which issue does this PR close?
None
Rationale for this change
This PR only updates the datafusion dependency to 52.3.0.