[Gemini] Fix bad-unpacking pyrefly error

[jrmccluskey]

Fix the bad-unpacking pyrefly error in yaml_ml.py. Generated via Gemini and Antigravity as a POC for letting generative models handle lightweight fixes.

Part of #37699

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a pyrefly bad-unpacking error that was occurring in the yaml_ml.py module. The fix involves a minor code adjustment to ensure proper type handling, allowing the removal of a previously ignored linting rule. This change also serves as a proof-of-concept for leveraging generative AI tools like Gemini and Antigravity for automated, lightweight code corrections.

Highlights

• Fix bad-unpacking error in yaml_ml.py: Corrected a bad-unpacking error in sdks/python/apache_beam/yaml/yaml_ml.py by explicitly casting the inference_tag to a string when constructing a beam.Row object, ensuring proper key handling.
• Remove pyrefly ignore rule: Removed the bad-unpacking = "ignore" entry from sdks/python/pyrefly.toml, as the underlying issue causing the error has been resolved by the code change.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/apache_beam/yaml/yaml_ml.py
  • Modified the beam.Map transformation to ensure inference_tag is a string before being used as a key in beam.Row.
• sdks/python/pyrefly.toml
  • Removed the bad-unpacking = "ignore" entry from the pyrefly configuration.

Activity

• The pull request was created by jrmccluskey.
• The changes were generated via Gemini and Antigravity as a proof-of-concept for generative models handling lightweight fixes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[jrmccluskey]

assign set of reviewers

[github-actions]

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[claudevdm]

/gemini review

[gemini-code-assist]

Code Review

This pull request fixes a bad-unpacking pyrefly error in yaml_ml.py by explicitly casting inference_tag to a string before using it as a dictionary key for keyword argument unpacking. The corresponding ignore rule in pyrefly.toml is also removed. The change is correct and effectively resolves the issue. I've suggested a small refactoring to make the dictionary creation more idiomatic and consistent with the schema definition.

[gemini-code-assist]

While the explicit cast to str() is correct to fix the bad-unpacking error, the dictionary construction and unpacking can be made more idiomatic and concise. Placing the unpacked dictionary **row[0]._asdict() before the new field also makes the field order consistent with how the schema is constructed, improving readability.

          lambda row: beam.Row(**{**row[0]._asdict(), str(inference_tag): row[1]})).with_output_types(schema))