fix: add side effects flag so bundlers don't treeshake in prod#22
Open
eni4sure wants to merge 1 commit intoalloc:mainfrom
Open
fix: add side effects flag so bundlers don't treeshake in prod#22eni4sure wants to merge 1 commit intoalloc:mainfrom
eni4sure wants to merge 1 commit intoalloc:mainfrom
Conversation
eni4sure
changed the title
Author
|
CC: @aleclarson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added "sideEffects": true to package.json to prevent bundlers (e.g. Vite) from incorrectly tree-shaking the package during production builds.
Context
While using drizzle-plus in a TanStack-based project, the package was being tree-shaken in production builds and resulted in an error because the library polyfills for
drizzle-ormwere not added.Changes
This ensures bundlers such as Vite do not remove code that relies on side effects during production builds.