Move release and tag version into env vars to prevent template injection#3055
Merged
adamtheturtle merged 5 commits intomainfrom Mar 17, 2026
Merged
Move release and tag version into env vars to prevent template injection#3055adamtheturtle merged 5 commits intomainfrom
adamtheturtle merged 5 commits intomainfrom
Conversation
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
steps.calver.outputs.releaseandsteps.tag_version.outputs.new_taginto environment variables in run/command blocks to prevent template injection, following GitHub's recommended security pattern.See: https://docs.github.com/en/actions/concepts/security/script-injections
Note
Low Risk
Workflow-only changes that adjust how GitHub Actions expressions are passed into shell scripts; low functional risk but could break releases/CI if variables are miswired.
Overview
Hardens the
release.ymlworkflow by movingsteps.*.outputs.*values used insiderunblocks (e.g., release version for changelog underline andmodifiedFilescheck) intoenvvars before shell evaluation.Updates
test.ymlto passstrategy.job-indexviaJOB_INDEXand use it in the secrets-file copy command, reducing direct expression interpolation in shell.Removes the
template-injectionsuppression fromzizmor.ymlso the repo’s workflow security linter can flag these issues going forward.Written by Cursor Bugbot for commit 07d92f9. This will update automatically on new commits. Configure here.