Fix test coverage for boundary error handling#3052
Merged
adamtheturtle merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Removed unnecessary guard condition that was always true after commit d7ea250 changed the */* boundary error from INTERNAL_SERVER_ERROR to BAD_REQUEST. Updated stale docstring in test_no_boundary that still referenced INTERNAL_SERVER_ERROR. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary guard condition in test_incorrect_no_boundary that was always true after a previous commit changed the / boundary error response from INTERNAL_SERVER_ERROR to BAD_REQUEST. Updated the test_no_boundary docstring to correctly reflect the BAD_REQUEST status code.
These changes improve test coverage by removing dead code.
Note
Low Risk
Low risk: changes are limited to test expectations/coverage for query boundary error handling and do not affect production logic.
Overview
Updates
tests/mock_vws/test_query.pyto always runhandle_server_errors()intest_incorrect_no_boundary, removing a dead/incorrect guard that skipped error handling for some responses.Also fixes the
test_no_boundarydocstring to match the current behavior that missing multipart boundaries returnHTTPStatus.BAD_REQUEST(notINTERNAL_SERVER_ERROR).Written by Cursor Bugbot for commit f132402. This will update automatically on new commits. Configure here.