Conversation
dependabot
bot
added
dependencies
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Interestingly, this update seems to cause similar breakages to #1293 even though a different component is being upgraded: play buttons no longer render correctly in MediaElement. Perhaps solving one problem will help with the other. I also see from the changelog that there are some significant changes like renamed configuration options which should be carefully reviewed to make sure our internal logic remains compatible with the upstream code.
|
@dependabot rebase |
Bumps [mediaelement](https://github.com/mediaelement/mediaelement) from 4.2.15 to 7.0.7. - [Release notes](https://github.com/mediaelement/mediaelement/releases) - [Changelog](https://github.com/mediaelement/mediaelement/blob/master/changelog.md) - [Commits](mediaelement/mediaelement@4.2.15...7.0.7) --- updated-dependencies: - dependency-name: mediaelement dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/dev/mediaelement-7.0.7
branch
from
40df39b to
0fc3d9d
Compare
|
The problem here appears to be that MediaElement is trying to download |
|
I've done some more digging: the issue is that there is now an iconSprite config setting that needs to be configured to point at the SVG spritesheet used by the player. I'm just not sure what value to put here (and/or what corresponding Webpack configuration to use) in order to make this work as expected. Investigating this also brought my attention to the fact that our current Webpack configuration uses deprecated methods for retrieving assets; we may want to modernize on Asset Modules at some point. I'm not sure at a glance whether or not that would also make this current problem easier to solve. |
|
I also tried converting the SVG into a data URI using https://www.svgviewer.dev and embedding it directly into the code -- this would be an inefficient solution, but I was curious if it would at least get things working. It did not work for me. |
|
Require more time to investigate the issue. |
|
I also had the idea to try using a CDN, since the SVG we need is available at https://cdnjs.cloudflare.com/ajax/libs/mediaelement/7.0.7/mejs-controls.svg -- but of course the same-origin policy prevents that idea from working. |
|
Finally getting somewhere -- see the Webpack config changes in c528770. |
|
A newer version of mediaelement exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
2 participants
Bumps mediaelement from 4.2.15 to 7.0.7.
Release notes
Sourced from mediaelement's releases.
... (truncated)
Changelog
Sourced from mediaelement's changelog.
... (truncated)
Commits
1db4583release 7.0.7f050117Remove a symlink that got accidentally pushed into git repository706ffc0release 7.0.66885ab0Add screen reader text for total duration when current and duration are conse...430b7caAdd screen reader text for current time and total duration751c699Add keyboard controls for play and pause to container element0026d05release 7.0.5c904ba8release 7.0.522c4eaeremoved setByKeyboard from setTrack function call73e50ceremoved setByKeyboard on tracks since it sets a wrong focusMaintainer changes
This version was pushed to npm by dpxgit, a new releaser for mediaelement since your current version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)TODO: