Skip to content

[WIP] [WIP] Address feedback on core Python/Matplotlib version contract checks #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

[WIP] [WIP] Address feedback on core Python/Matplotlib version contract checks #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61cbe1e
Initial plan
Copilot Mar 12, 2026
ae0dcd1
Fix _expand_half_open_minor_range infinite loop on cross-major versio…
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tools/ci/version_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ def _expand_half_open_minor_range(spec: str) -> list[str]:
return []
major_min, minor_min = map(int, min_match.group(1).split("."))
major_max, minor_max = map(int, max_match.group(1).split("."))
if major_min != major_max:
raise ValueError(
f"Version constraint '{spec}' spans major versions "
f"({major_min} -> {major_max}); only single-major ranges are supported."
)
versions = []
major, minor = major_min, minor_min
while (major, minor) < (major_max, minor_max):
Expand Down
11 changes: 11 additions & 0 deletions ultraplot/tests/test_core_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import re
from pathlib import Path

import pytest

ROOT = Path(__file__).resolve().parents[2]
PYPROJECT = ROOT / "pyproject.toml"
MAIN_WORKFLOW = ROOT / ".github" / "workflows" / "main.yml"
Expand Down Expand Up @@ -67,3 +69,12 @@ def test_publish_workflow_python_is_supported():
match = re.search(r'python-version:\s*"(\d+\.\d+)"', text)
assert match is not None
assert match.group(1) in supported


def test_expand_half_open_minor_range_rejects_cross_major_constraints():
"""
Cross-major constraints (e.g. ">=3.10,<4.0") must raise ValueError immediately.
"""
version_support = _load_version_support()
with pytest.raises(ValueError, match=r"spans major versions \(3 -> 4\)"):
version_support._expand_half_open_minor_range(">=3.10,<4.0")