Conversation
There was a problem hiding this comment.
Pull request overview
Adds new heap integrity validation to detect GC heap corruption and abort early, integrated into key GC lifecycle points and global tracing to surface memory/list corruption issues closer to their source.
Changes:
- Introduces
validate_heap_objects(lua_State *L, const char *where)to walkL->heap->objectsand validate node pointers/type/ownership, aborting on failure. - Calls this validation before/after heap transfer in
luaC_inherit_thread()and at multiple stages oflocal_collection(). - Adds basic corruption checks inside
trace_heap()during global tracing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Note
Medium Risk
Touches core GC heap list manipulation and adds frequent validation/abort paths, which could impact performance or change failure modes (hard abort) if invariants are violated.
Overview
Adds debug-only style heap integrity checks around GC heap
TAILQoperations to catch corruption early. A newvalidate_heap_objects()walk and targeted post-TAILQ_INSERT_HEADbacklink checks verify object pointers,ttrange,owner, andtqe_prev/tqe_nextlinkage, aborting viatailq_abort()with detailed logging.Runs these validations at key points in
new_obj,luaC_inherit_thread(before/after transfer),local_collection(entry, after marking, before/after reclaim, after finalization/free), andtrace_heap, and reordersfinalize_deferred()to run before unblocking the collector to keep heap invariants checked during finalization.Written by Cursor Bugbot for commit 99db8c3. This will update automatically on new commits. Configure here.