Add deprecation message to use of copy#1430
Open
SteveL-MSFT wants to merge 2 commits intoPowerShell:mainfrom
Open
Add deprecation message to use of copy#1430SteveL-MSFT wants to merge 2 commits intoPowerShell:mainfrom
copy#1430SteveL-MSFT wants to merge 2 commits intoPowerShell:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Marks use of the copy loop construct in configuration documents as deprecated by emitting a warning during config validation, and adds a regression test to ensure the warning is surfaced to users.
Changes:
- Emit a localized warning when a resource contains a
copyblock. - Add an English locale string for the deprecation warning message.
- Add a PowerShell test asserting the warning appears on stderr when
copyis used.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/dsc-lib/src/configure/mod.rs | Emits a warning when validating a config that contains copy. |
| lib/dsc-lib/locales/en-us.toml | Adds the localized deprecation warning string. |
| dsc/tests/dsc_copy.tests.ps1 | Adds a test that verifies copy triggers a deprecation warning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As discussed in WG, mark
copyas deprecatedPR Context
Fix #1429