Open
Conversation
I realized after creating this PR that the IDs in the encounter.csv were incorrect at the end of it.
Removed --break-system-packages option from install and dev-install commands. Usually need this for my own machine.
Contributor
|
I'll take a look at this soon, but as for your question on encounter slots yes. From what I've seen, these have been re-used for encounters with the same properties and I do not think there are any unintended consequences for that. |
jemarq04
suggested changes
Mar 14, 2026
Comment on lines
+65355
to
+65359
| 70914,25,1229,1350,431,36,38 | ||
| 70915,25,1229,1351,548,36,38 | ||
| 70916,26,1229,1348,114,36,38 | ||
| 70917,26,1229,1349,191,36,38 | ||
| 70918,26,1229,1350,431,36,38 |
Contributor
There was a problem hiding this comment.
Suggested change
| 70914,25,1229,1350,431,36,38 | |
| 70915,25,1229,1351,548,36,38 | |
| 70916,26,1229,1348,114,36,38 | |
| 70917,26,1229,1349,191,36,38 | |
| 70918,26,1229,1350,431,36,38 | |
| 70914,25,1229,1350,432,36,38 | |
| 70915,25,1229,1351,548,36,38 | |
| 70916,26,1229,1348,114,36,38 | |
| 70917,26,1229,1349,191,36,38 | |
| 70918,26,1229,1350,432,36,38 |
Purugly is available here, not Glameow
Comment on lines
+65347
to
+65351
| 70906,25,1228,1350,431,36,38 | ||
| 70907,25,1228,1351,37,36,38 | ||
| 70908,26,1228,1348,114,36,38 | ||
| 70909,26,1228,1349,191,36,38 | ||
| 70910,26,1228,1350,431,36,38 |
Contributor
There was a problem hiding this comment.
Suggested change
| 70906,25,1228,1350,431,36,38 | |
| 70907,25,1228,1351,37,36,38 | |
| 70908,26,1228,1348,114,36,38 | |
| 70909,26,1228,1349,191,36,38 | |
| 70910,26,1228,1350,431,36,38 | |
| 70906,25,1228,1350,432,36,38 | |
| 70907,25,1228,1351,37,36,38 | |
| 70908,26,1228,1348,114,36,38 | |
| 70909,26,1228,1349,191,36,38 | |
| 70910,26,1228,1350,432,36,38 |
Purugly is available here, not Glameow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes additions for the missing Mirage Forest encounters for ORAS.
Luckily there's no Gen 3 equivalent for this and the last few Mirage Spots.
Also question about encounter slots, there's no harm in reusing them for multiple encounter types, correct? Just don't want to balloon that file with, in essence, duplicate entries.