Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for CMAP terms in the Sire-to-OpenMM conversion layer. This turned out to be fairly straightforward, with the main complication being the different grid ordering used internally by OpenMM. The AMBER format stores the grid with phi varying slowest in column-major order, while OpenMM expects the grid with a half-period cyclic shift applied to both axes and the phi/psi axes swapped.
Unit tests confirm that a system containing CMAP terms converted to an OpenMM system with Sire gives identical energies to what would be obtained using the OpenMM Python API directly. A second unit test performs initial validation for the perturbable CMAP implementation by validating the protein CMAP terms are unmodified when changing lambda for a one-to-one mapping between residues in a protein backbone. (This also validates that the BioSimSpace CMAP merging is working correctly.) I'll add a unit test to BioSimSpace when I have an example protein mutation that involves CMAP terms.
The PR also closes #405 by adding a timeout to the GROMACS archive download in
sire.load.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]