Skip to content

Added checks#1660

Merged
twerthi merged 3 commits intoOctopusDeploy:masterfrom
lrochette:master
Mar 13, 2026
Merged

Added checks#1660
twerthi merged 3 commits intoOctopusDeploy:masterfrom
lrochette:master

Conversation

@lrochette
Copy link
Contributor

Background

Added checks for Argo Workflow CLI presence and workflow template name

Results

Catch errors earlier

Before

step would have failed weirdly

After

argo executable could not be found. Please use a target or container including it like octopuslabs/argo-workflow-workertools. 

or

WorkflowTemplate name is required 

Pre-requisites

  • [x ] Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • [ x] Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • [x ] Parameter names should not start with $
  • [ x] Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • [ x] LastModifiedBy field must be present, and (optionally) updated with the correct author
  • [ x] The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

@github-actions
Copy link

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

Copy link
Contributor

@twerthi twerthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twerthi twerthi merged commit 74ec81e into OctopusDeploy:master Mar 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants