[19.0][MIG] document_page_approval: Migration to 19.0#592
Closed
gregory-rutecki wants to merge 69 commits intoOCA:19.0from
Closed
[19.0][MIG] document_page_approval: Migration to 19.0#592gregory-rutecki wants to merge 69 commits intoOCA:19.0from
gregory-rutecki wants to merge 69 commits intoOCA:19.0from
Conversation
(../7.0pageapproval/ rev 1) fix status bar in page approval (../7.0pageapproval/ rev 2) change approval workflow in page history and started to add showing approved page in normal page (../7.0pageapproval/ rev 3) show last approved content and aproved by (../7.0pageapproval/ rev 4) Fix bug on page creation (../7.0pageapproval/ rev 5) add status in history tree view (../7.0pageapproval/ rev 6) add a need approval field and hide the workflow when no approval needed (../7.0pageapproval/ rev 7) add access validation to approval (../7.0pageapproval/ rev 8) give rigth to Page aprover group on the page_history model and hide the button for unallowed group thought the security isn't enforced a the orm level (../7.0pageapproval/ rev 9) made invisible the prover group when not needed (../7.0pageapproval/ rev 10) add email to aprovers group's members (../7.0pageapproval/ rev 11)
[ADD] Translation file + french [FIX] employee_id field does not exist [FIX] user_email field deprecated [IMP] Split long lines [ADD] Images
fix act_draft and minor ui fix remove unused variables change order of xml data files
It should work but further errors could help understand what's going Commented other necessary part Add back workflow Add dependency to knowledge
[IMP] - Improved views to match document_page improvements. [IMP] - Added notification to followers when a new version is approved. [ADD] - Updated document_page_approval pot and added es translations. [IMP] - document_page_approval: Updated spanish translation.
…te module is installed.
* Lint error corrected * test improved * lint error corrected in test file * readme corrected * test improved * test of document page history workflow added * CI error corrected * dreipst comment * Migration to new api improved in model's file and data tag remove in xml file * code totally migrate to odoo 9.0 api * test bug fixed * test error fixed * Lint error improved
…ovements on documents (OCA#155)
* Rename classes and files to match model names, and removed workflow engine. * Some fields should be readonly if not in draft. * Allow Knowledge / Manager to edit previous history names and summary * Improve ux by adding user_has_drafts to document pages. * Changes because of implementation of active field on document_page * Add ir.rules for document.page.history * Allow to quickly cancel&draft from 'to approve' state * FIX BUG: am_i_approver was being run as sudo(), hence always giving the user Approving rights. * FIX hooks Because of default='draft' on the state field, state IS NULL wasn't selecting anything. Left the condition in case this is changed in the future.
[ADD] icon.png
Add the the group eployee to the rule "Change Request Global" to allow to the user with the rule "Change Request Approver" to create pages
[UPD] Update document_page_approval.pot
To pass test is necesary set approval required to False in demo data
[UPD] Update document_page_approval.pot [UPD] README.rst
TT36950 [UPD] Update document_page_approval.pot [UPD] README.rst
[UPD] Update document_page_approval.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/ Translated using Weblate (Italian) Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
Currently translated at 83.6% (51 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/hr/ Translated using Weblate (Croatian) Currently translated at 96.7% (59 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/hr/
Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/
[UPD] Update document_page_approval.pot document_page_approval 16.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
Currently translated at 96.7% (59 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/ Translated using Weblate (Italian) Currently translated at 96.7% (59 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/ [UPD] Update document_page_approval.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/
Changes done: - Squash administrative commits - Purge translations - Remove ir.model.access.csv file - Improve tests (change to setUpClass) - Replace name_get() to _compute_display_name() (document_page) - Remove readonly=1 (redudant, it already is) defined in approved_uid and approved_date fields in views - Restore readonly=1 to the state field - Remove duplicate Back to draft button TT51529
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-17.0/knowledge-17.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_page_approval/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-17.0/knowledge-17.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_page_approval/
Currently translated at 100.0% (62 of 62 strings) Translation: knowledge-17.0/knowledge-17.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_page_approval/it/
Currently translated at 98.3% (61 of 62 strings) Translation: knowledge-17.0/knowledge-17.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_page_approval/es/
Steps to reproduce the error: - Modify the content of a page (with a different user). - Go to the Change request menu and Cancel the change. - Click on the "Back to draft" button. - An error will be displayed TT55569
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-18.0/knowledge-18.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_approval/
Currently translated at 100.0% (59 of 59 strings) Translation: knowledge-18.0/knowledge-18.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_approval/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-18.0/knowledge-18.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_approval/
Currently translated at 100.0% (62 of 62 strings) Translation: knowledge-18.0/knowledge-18.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_approval/sv/
…ry and send mail Example use case: - Modify the Odoo Features category, check Require approval, and set Approver group > Administration / Access Rights - Modify the Marc Demo user and define Document Knowledge > Editor permissions - Go to the Odoo Features category and, taking into account the ID, delete the mail_message record table with the same ID from the database - With the Marc Demo user, go to the Knowledge > Odoo Features menu and enter the Odoo 15.0 Functional Demo page (it is important to follow these specific steps) - Modify the page and save Before this change, an error could occur because the action https://github.com/OCA/knowledge/blob/0881d75a35e7fc2f814110df4878177e805e589b/document_page/views/document_page_category. xml#L83C17-L83C42 defined a default_parent_id=x (page category ID) if there was no mail_message linked to that category ID; now the value of default_parent_id is removed to avoid this specific error. TT61290
gregory-rutecki
force-pushed
the
19.0-mig-document_page_approval
branch
from
e9cfbdb to
55e527c
Compare
Author
|
Closing in favor of #573 — reviewed and approved the existing PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration of
document_page_approvalto Odoo 19.0.Depends on: #591 (document_page)
Changes:
res.groups:category_id→privilege_idres.users:groups_id→group_ids(search domain + tests)user.groups_id→user.group_ids(Python)fields.datetime.now()→fields.Datetime.now()(lowercase alias removed in v19)Testing
Tested on live Odoo 19.0 — approval workflow works correctly.
🤖 Generated with Claude Code